Skip to content

[PWGCF] Fix includes and using statements#15383

Merged
vkucera merged 4 commits intoAliceO2Group:masterfrom
vkucera:fixes-PWGCF
Apr 16, 2026
Merged

[PWGCF] Fix includes and using statements#15383
vkucera merged 4 commits intoAliceO2Group:masterfrom
vkucera:fixes-PWGCF

Conversation

@vkucera
Copy link
Copy Markdown
Collaborator

@vkucera vkucera commented Mar 13, 2026

No description provided.

@github-actions github-actions bot changed the title Fix includes and using statements [PWGCF] Fix includes and using statements Mar 13, 2026
@vkucera vkucera force-pushed the fixes-PWGCF branch 4 times, most recently from 056e246 to 6e17d18 Compare March 26, 2026 09:43
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

O2 linter results: ❌ 3400 errors, ⚠️ 5219 warnings, 🔕 53 disabled

@vkucera vkucera force-pushed the fixes-PWGCF branch 5 times, most recently from e0af7d5 to 79d6e5f Compare April 9, 2026 16:30
Copy link
Copy Markdown
Contributor

@jgrosseo jgrosseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for CorrelationContainer, correlations, filterCorrelations, filter2Prong

@vkucera
Copy link
Copy Markdown
Collaborator Author

vkucera commented Apr 13, 2026

@victor-gonzalez @otonvd @shouqiye Can you please review the PR?

@vkucera
Copy link
Copy Markdown
Collaborator Author

vkucera commented Apr 14, 2026

@victor-gonzalez @otonvd @shouqiye Ping

ariedel-cern
ariedel-cern previously approved these changes Apr 15, 2026
Copy link
Copy Markdown
Collaborator

@ariedel-cern ariedel-cern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Femto/FemtoDream everythings seems good

@vkucera
Copy link
Copy Markdown
Collaborator Author

vkucera commented Apr 15, 2026

Dear @victor-gonzalez @otonvd @shouqiye , this is my third reminder to you to review the PR.
It has been opened for the last four working days and in the meantime, I've had to resolve conflicts twice. I would appreciate a timely review, approval, and merging.

@vkucera vkucera merged commit 581c41c into AliceO2Group:master Apr 16, 2026
11 of 14 checks passed
@vkucera vkucera deleted the fixes-PWGCF branch April 16, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants